Skip to content

Skip Dockerfile-specific .dockerignore files without warnings - #1908

Merged
Greg Villicana (grvillic) merged 2 commits into
mainfrom
copilot/dockerfile-detector-ignore-valid-files
Nov 9, 2026
Merged

Skip Dockerfile-specific .dockerignore files without warnings#1908
Greg Villicana (grvillic) merged 2 commits into
mainfrom
copilot/dockerfile-detector-ignore-valid-files

Conversation

Copilot AI commented Nov 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Broad Dockerfile matching includes valid ignore files such as Dockerfile.dockerignore, causing false parser warnings.

  • Filtering: Exclude filenames ending in .dockerignore, case-insensitively, before logging or parsing. Preserve detection of Dockerfile, Dockerfile.runtime, and other supported variants.
  • Regression coverage: Check silent exclusion regardless of file contents and continued detection of genuine Dockerfiles.

New Detector Checklist

Not applicable: updates an existing detector.

  • I have gone through the docs for creating a new detector here
  • My new detector implements IDefaultOffComponentDetector
  • I have created a PR to the verification repo with components that my new detector can find
  • (If necessary) I have updated the Feature Overview table in the README

Copilot AI balanced review requested due to automatic review settings November 1, 2026 21:19
Copilot AI reviewed Nov 1, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

Copilot AI linked an issue Nov 1, 2026 that may be closed by this pull request
Dockerfile detector warns on valid Dockerfile.dockerignore files #1907
Closed
@grvillic
Skip Dockerfile-specific dockerignore files without warnings
7a38a16 
Co-authored-by: grvillic <58237075+grvillic@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 1, 2026 21:23
Copilot AI reviewed Nov 1, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the change excluding Dockerfile-specific .dockerignore files from parsing.

No open issues 🎉

Review effort: Balanced

Copilot AI changed the title [WIP] Fix Dockerfile detector warnings on valid Dockerfile.dockerignore files Skip Dockerfile-specific .dockerignore files without warnings Nov 1, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@grvillic
Greg Villicana (grvillic) marked this pull request as ready for review November 9, 2026 01:03
@grvillic
Greg Villicana (grvillic) requested a review from a team as a code owner November 9, 2026 01:03
@codecov

codecov Bot commented Nov 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.0%. Comparing base (d2b7149) to head (7a38a16).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@     Coverage Diff      @@
##   main   #1908   +/-   ##
============================
============================

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grvillic
Greg Villicana (grvillic) merged commit 5ac4517 into main Nov 9, 2026
18 checks passed
@grvillic
Greg Villicana (grvillic) deleted the copilot/dockerfile-detector-ignore-valid-files branch November 9, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@ryanbrandenburg Ryan Brandenburg (ryanbrandenburg) ryanbrandenburg approved these changes
+1 more reviewer
@grvillic Greg Villicana (grvillic) grvillic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@grvillic Greg Villicana (grvillic)

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dockerfile detector warns on valid Dockerfile.dockerignore files

4 participants

@ryanbrandenburg @grvillic